Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(promotion): scope uniqueness index to non deleted promotions #11624

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Feb 26, 2025

what:

  • scopes uniqueness index to only non deleted records
  • explicit sorting of buy get promotions
    • This error popped up as we removed the uniqueness constraint which seems to have kept a specific order.

RESOLVES #11606

Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 2:25pm
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 26, 2025 2:25pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 2:25pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 2:25pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 2:25pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 2:25pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 2:25pm
user-guide ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 2:25pm

Copy link

changeset-bot bot commented Feb 26, 2025

⚠️ No Changeset found

Latest commit: d9513e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riqwan riqwan marked this pull request as ready for review February 26, 2025 13:12
@riqwan riqwan requested a review from a team as a code owner February 26, 2025 13:12
@kodiakhq kodiakhq bot merged commit a515e6e into develop Feb 26, 2025
24 checks passed
@kodiakhq kodiakhq bot deleted the fix/promotion-index branch February 26, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: promotions unique code soft delete error
3 participants