Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(medusa): deleting location level #11630

Merged
merged 2 commits into from
Feb 27, 2025
Merged

fix(medusa): deleting location level #11630

merged 2 commits into from
Feb 27, 2025

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Feb 26, 2025 •
edited
Loading

What

  • when deleting an inventory location level, a wrong RQ argument would result in a wrong location level being returned

@fPolic fPolic requested a review from a team as a code owner February 26, 2025 16:42
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d87398e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 8:29am
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 27, 2025 8:29am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 8:29am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 8:29am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 8:29am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 8:29am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 8:29am
user-guide ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 8:29am

@fPolic fPolic requested review from olivermrbl and removed request for sradevski February 26, 2025 16:44
olivermrbl
olivermrbl approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olivermrbl olivermrbl merged commit 12cf24a into develop Feb 27, 2025
24 checks passed
@olivermrbl olivermrbl deleted the fix/inventory-level-delete branch February 27, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fPolic @olivermrbl