Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): Prevent sub workflow events release early + redis unlink #11641

Merged
merged 7 commits into from
Feb 27, 2025

Conversation

adrien2p
Copy link
Member

What

  • Prevent event release when a workflow is run as step and finish
  • Use unlink instead of del when removing keys from redist to push the execution to async thread

@adrien2p adrien2p marked this pull request as ready for review February 27, 2025 09:45
@adrien2p adrien2p requested a review from a team as a code owner February 27, 2025 09:45
Copy link

changeset-bot bot commented Feb 27, 2025

🦋 Changeset detected

Latest commit: 45e0bd8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 65 packages
Name Type
@medusajs/cache-redis Patch
@medusajs/event-bus-redis Patch
@medusajs/workflow-engine-redis Patch
@medusajs/locking-redis Patch
@medusajs/workflows-sdk Patch
@medusajs/medusa Patch
@medusajs/test-utils Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/cache-inmemory Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/event-bus-local Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/order Patch
@medusajs/payment Patch
@medusajs/pricing Patch
@medusajs/product Patch
@medusajs/promotion Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/stock-location Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/user Patch
@medusajs/workflow-engine-inmemory Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/core-flows Patch
@medusajs/framework Patch
@medusajs/js-sdk Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/types Patch
@medusajs/utils Patch
@medusajs/cli Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch
@medusajs/telemetry Patch
@medusajs/admin-bundler Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/admin-vite-plugin Patch
@medusajs/dashboard Patch
@medusajs/icons Patch
@medusajs/toolbox Patch
@medusajs/ui-preset Patch
create-medusa-app Patch
medusa-dev-cli Patch
integration-tests-http Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 10:19am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 10:19am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 10:19am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 10:19am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 10:19am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 10:19am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 10:19am
user-guide ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 10:19am

@kodiakhq kodiakhq bot merged commit c250de7 into develop Feb 27, 2025
24 checks passed
@kodiakhq kodiakhq bot deleted the chore/redis-unlink branch February 27, 2025 10:34
@github-actions github-actions bot mentioned this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants