fix(medusa): Remove default job age option from EventBus #3388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Revert EventBusService to not have default job age option
Why
Bull does not forward nested objects in job configurations correctly to Redis.
Options that are part of a nested object are ignored completely:
You can only pass top-level options, meaning the following works:
When nested object options are passed to Redis, they have the following shape:
So they won't be picked up.To add to that, stringifying the options in theemit
call (which is something I would expect Bull would do for us under the hood), does not work inbull
, only inbullmq
.Stringifying turned out not to be the issue. Nested options do not work at all in
bull
. I am yet to find out why. Have reached out to the maintainer.