-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(medusa): Performance improvement for variant availability #3921
fix(medusa): Performance improvement for variant availability #3921
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: caac43a The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@olivermrbl would love to have a talk w/ @adrien2p about this before merging since he probably has opinions here 😉 adding |
Sure, can I get you to add in the PR description, what you would like to discuss? |
Would it be possible to include benchmarks of the effect of these changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work 💪
The benchmark won't show much, but we go from 600 queries to 1 query instead, which has quite of an impact, instead of having the numbers of queries growing in correlation of the number of variants, it is constant :) |
What
@adrien2p would love to run through some tests of this with you and get your take on approach