Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(medusa): migrations cli should also pull from ${plugin}/dist #3956

Merged

Conversation

dwene
Copy link
Contributor

@dwene dwene commented Apr 28, 2023

Now that Medusa accepts javascript in the root or in dist folders of a plugin, it should also look for migrations in the dist folder of a published plugin.

@dwene dwene requested a review from a team as a code owner April 28, 2023 18:58
@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2023

🦋 Changeset detected

Latest commit: c9c1705

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@medusajs/medusa Patch
@medusajs/admin-ui Patch
@medusajs/admin Patch
@medusajs/medusa-js Patch
medusa-payment-paypal Patch
medusa-payment-stripe Patch
medusa-plugin-restock-notification Patch
medusa-react Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 28, 2023

@dwene is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@olivermrbl olivermrbl requested a review from adrien2p May 3, 2023 08:17
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have you been able to test it just to be sure? It should work but just to double check

@dwene
Copy link
Contributor Author

dwene commented May 3, 2023

@adrien2p yep! I only found this because we started breaking up our code into plug-ins in a monorepo and found the migrations weren't working.

@vercel
Copy link

vercel bot commented May 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) May 23, 2023 10:39am

@olivermrbl olivermrbl merged commit e3cfbcd into medusajs:develop May 28, 2023
@github-actions github-actions bot mentioned this pull request May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants