feat(medusa,inventory,types): Expand list-reservation capabilities #3979
Conversation
🦋 Changeset detectedLatest commit: 950ac84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
packages/medusa/src/types/common.ts
Outdated
| @@ -164,6 +168,28 @@ export class StringComparisonOperator { | |||
| lte?: string | |||
| } | |||
|
|
|||
| export class StringSearchOperator { | |||
There was a problem hiding this comment.
thought(non-blocking): Are these necessary? Wouldn't it suffice to use our existing simple text search mechanism?
Just dreading that we are adding unnecessary complexity to the UI implementation/filters in admin. What's your take?
There was a problem hiding this comment.
I think it is nice to have but maybe not a must, something we can discuss but otherwise I ve written a comment to move the prepare method to an util as part of the buildQuery utils.
There was a problem hiding this comment.
Yeah, think it is a nice-to-have, but I am fine keeping it in. I like the verbosity of this approach compared to alternatives. And this is consistent with the in and nin` operators introduced in the products module.
@srindom – I would like you to sign off on this too :)
There was a problem hiding this comment.
We generally use snake_case for things passed to the API, so if we keep the StringSearchOperator, we could change that.
I realise we haven't had nested "multi-syllable word filters" (only lte, gt, etc.), but I just thought it would make for a more consistent API.
packages/medusa/src/api/routes/admin/reservations/list-reservations.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/api/routes/admin/reservations/list-reservations.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/types/common.ts
Outdated
| @@ -164,6 +168,28 @@ export class StringComparisonOperator { | |||
| lte?: string | |||
| } | |||
|
|
|||
| export class StringSearchOperator { | |||
There was a problem hiding this comment.
I think it is nice to have but maybe not a must, something we can discuss but otherwise I ve written a comment to move the prepare method to an util as part of the buildQuery utils.
|
@adrien2p – can I get you to give this another round of review today to not let it hang? :) |
Sure I ll do another round |
|
@olivermrbl I updated the description querying as discussed, wanna take another look? |
What
How
Fixes CORE-1373