Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(medusa): Only set product availability if variants are requested #4010

Merged
merged 3 commits into from
May 4, 2023
Merged

fix(medusa): Only set product availability if variants are requested #4010

merged 3 commits into from
May 4, 2023

Conversation

olivermrbl
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 3, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 6c9a87b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@medusajs/medusa Patch
@medusajs/admin-ui Patch
@medusajs/admin Patch
@medusajs/medusa-js Patch
medusa-payment-paypal Patch
medusa-payment-stripe Patch
medusa-plugin-restock-notification Patch
medusa-react Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) May 4, 2023 6:59am

@olivermrbl
Copy link
Contributor Author

/snapshot-this

@olivermrbl olivermrbl requested review from pKorsholm and adrien2p May 3, 2023 18:38
@olivermrbl olivermrbl marked this pull request as ready for review May 3, 2023 18:49
@olivermrbl olivermrbl requested a review from a team as a code owner May 3, 2023 18:49
pKorsholm
pKorsholm approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@pKorsholm pKorsholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

adrien2p
adrien2p requested changes May 4, 2023
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add this check in store get product as well wdyt?

@olivermrbl olivermrbl requested a review from adrien2p May 4, 2023 07:01
adrien2p
adrien2p approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the ci to pass

@olivermrbl olivermrbl merged commit 284f1ee into develop May 4, 2023
@olivermrbl olivermrbl deleted the fix/product-availability branch May 4, 2023 07:29
@github-actions github-actions bot mentioned this pull request May 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p approved these changes

@pKorsholm pKorsholm pKorsholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olivermrbl @adrien2p @pKorsholm