feat(medusa): Remove sqlite support #4026

olivermrbl · 2023-05-05T14:24:39Z

What
Remove support for SQLite

Why
SQLite support was initially added to reduce friction for developers looking to try out Medusa. It runs on most operating systems without any installation, which means you'll be able to create and start a Medusa starter without configuration.

Though, as we've added features that use more advanced database concepts, we've seen that SQLite is now causing more harm than good. It still allows developers to get a server up and running very quickly, but as soon as you start playing around with our admin system or the storefront starter, you'll experience issues caused by the limitations of SQLite. The issues are primarily centered around transaction management. A concept used extensively in our core and poorly supported by SQLite.

We've concluded that these issues are causing too many headaches for our users and require too much assistance from our side for it to be worth it. Therefore, we are removing SQLite from our core and will only support Postgres for the time being.

changeset-bot · 2023-05-05T14:24:43Z

🦋 Changeset detected

Latest commit: a354cde

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages

Name	Type
@medusajs/medusa-cli	Patch
medusa-plugin-contentful	Patch
@medusajs/medusa	Patch
@medusajs/utils	Patch
@medusajs/admin-ui	Patch
@medusajs/admin	Patch
@medusajs/medusa-js	Patch
medusa-payment-paypal	Patch
medusa-payment-stripe	Patch
medusa-plugin-meilisearch	Patch
medusa-plugin-restock-notification	Patch
medusa-react	Patch
@medusajs/medusa-oas-cli	Patch
@medusajs/event-bus-local	Patch
@medusajs/event-bus-redis	Patch
@medusajs/inventory	Patch
medusa-plugin-algolia	Patch
@medusajs/modules-sdk	Patch
@medusajs/stock-location	Patch
@medusajs/oas-github-ci	Patch
@medusajs/cache-inmemory	Patch
@medusajs/cache-redis	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2023-05-05T14:24:43Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
medusa-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 17, 2023 9:39am

olivermrbl · 2023-05-07T10:24:02Z

We will also need to remove all mention of sqlite in our documentation cc @shahednasser

…sa into feat/remove-sqlite-support

olivermrbl · 2023-05-07T13:06:36Z

packages/medusa/src/loaders/database.ts

+    await dataSource.initialize()
+  } catch (err) {
+    // database name does not exist
+    if (err.code === "3D000") {


comment: Hopefully, that'll reduce friction just a tiny bit

question: Should we always throw an error to prevent swallowing it?

olivermrbl · 2023-05-08T11:45:01Z

packages/medusa/src/loaders/database.ts

+    try {
+      await dataSource.query(`select * from migrations`)
+    } catch (err) {
+      if (err.code === "42P01") {


comment: Another one to reduce friction and make it easier to get started

Same question as the previous one

packages/medusa/src/loaders/database.ts

spacewalkingninja · 2023-05-09T17:01:10Z

Yeah and there is no MySql//MariaDB support MAKING US USE 20 MB OF RAM FOR EVERY CONNECTION WE NEED TO MAKE!
This is unfair and very resource wasteful, not ecological at all.
All this because you want transactions and things.
Just insert and update things and stuff works like back when we were script kiddies that just used PHP and some CMS downloaded from the net.

olivermrbl · 2023-05-11T08:21:08Z

/snapshot-this

olivermrbl · 2023-05-11T08:21:29Z

@adrien2p will you give this is a review when time allows for it?

github-actions · 2023-05-11T08:28:02Z

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]

yarn add @medusajs/[email protected]

yarn add @medusajs/[email protected]

yarn add @medusajs/[email protected]

yarn add @medusajs/[email protected]

yarn add @medusajs/[email protected]

yarn add @medusajs/[email protected]

yarn add @medusajs/[email protected]

yarn add @medusajs/[email protected]

yarn add @medusajs/[email protected]

yarn add [email protected]

yarn add [email protected]

yarn add [email protected]

yarn add [email protected]

yarn add [email protected]

yarn add [email protected]

yarn add [email protected]

yarn add @medusajs/[email protected]

yarn add @medusajs/[email protected]

yarn add @medusajs/[email protected]

yarn add @medusajs/[email protected]

Latest commit: 7963c16

spacewalkingninja · 2023-05-11T12:15:03Z

@olivermrbl YOU are ignoring my comment! It is a democratic opens source and here is open source opinion: sqlite support is a GOOD AND BVERY GOOD FEAT DO NOT REMOVE IT!

pKorsholm

LGTM! Just have a question and a nit suggestion 😄

packages/create-medusa-app/src/new-starter.js

packages/medusa/src/commands/seed.ts

riqwan

Looks good!

Should we also remove sqlite and better-sqlite from the main package.json?

packages/medusa/src/commands/seed.ts

olivermrbl · 2023-05-16T13:46:57Z

Should we also remove sqlite and better-sqlite from the main package.json?

From where? I believe they are removed already

olivermrbl · 2023-05-16T13:49:02Z

OU are ignoring my comment! It is a democratic opens source and here is open source opinion: sqlite support is a GOOD AND BVERY GOOD FEAT DO NOT REMOVE IT!

As you can read from the PR description, we've concluded that SQLite is causing more harm than good and will therefore be removed. It is virtually unusable even for the simplest cases, and we don't want to put in the effort to support it fully. We will soon be moving to a more ORM agnostic approach at which point, you'll be able to build support for it yourself.

Find a related comment here.

riqwan

nvm about the package question, i might've looked at an outdated file.

Thanks for moving the categories seed in the process! <3

adrien2p

LGTM with comments

packages/medusa/src/commands/seed.ts

adrien2p · 2023-05-17T07:43:46Z

packages/medusa/src/loaders/database.ts

+    await dataSource.initialize()
+  } catch (err) {
+    // database name does not exist
+    if (err.code === "3D000") {


question: Should we always throw an error to prevent swallowing it?

adrien2p · 2023-05-17T07:44:03Z

packages/medusa/src/loaders/database.ts

+    try {
+      await dataSource.query(`select * from migrations`)
+    } catch (err) {
+      if (err.code === "42P01") {


Same question as the previous one

adrien2p

LGTM with comments

feat(medusa): Remove sqlite support

fc39a24

Create tall-humans-count.md

68dde29

olivermrbl marked this pull request as ready for review May 7, 2023 10:24

olivermrbl requested a review from a team as a code owner May 7, 2023 10:24

olivermrbl added 2 commits May 7, 2023 12:26

add back column strategy for backward compat.

0d35c1e

Merge branch 'feat/remove-sqlite-support' of github.com:medusajs/medu…

bd7d763

…sa into feat/remove-sqlite-support

olivermrbl commented May 7, 2023

View reviewed changes

olivermrbl requested review from srindom and adrien2p May 8, 2023 08:22

olivermrbl commented May 8, 2023

View reviewed changes

srindom reviewed May 8, 2023

View reviewed changes

packages/medusa/src/loaders/database.ts Outdated Show resolved Hide resolved

add descriptive error

536db08

olivermrbl force-pushed the feat/remove-sqlite-support branch from f5b0173 to 536db08 Compare May 8, 2023 12:36

Merge branch 'develop' into feat/remove-sqlite-support

672eab8

vercel bot deployed to Preview May 9, 2023 14:39 View deployment

olivermrbl and others added 2 commits May 11, 2023 10:20

Deprecate database_type

b3889e3

Merge branch 'develop' into feat/remove-sqlite-support

07a4241

vercel bot deployed to Preview May 11, 2023 08:27 View deployment

olivermrbl requested review from riqwan and pKorsholm May 16, 2023 06:59

pKorsholm approved these changes May 16, 2023

View reviewed changes

packages/create-medusa-app/src/new-starter.js Outdated Show resolved Hide resolved

packages/medusa/src/commands/seed.ts Show resolved Hide resolved

riqwan approved these changes May 16, 2023

View reviewed changes

olivermrbl added 2 commits May 16, 2023 12:04

Merge branch 'develop' into feat/remove-sqlite-support

3366424

Address PR feedback

b2b4dd6

olivermrbl commented May 16, 2023

View reviewed changes

packages/medusa/src/commands/seed.ts Show resolved Hide resolved

olivermrbl requested review from riqwan and pKorsholm May 16, 2023 10:08

riqwan approved these changes May 16, 2023

View reviewed changes

adrien2p approved these changes May 17, 2023

View reviewed changes

olivermrbl and others added 2 commits May 17, 2023 11:31

address pr feedback

821990d

Merge branch 'develop' into feat/remove-sqlite-support

a354cde

olivermrbl added the automerge label May 17, 2023

vercel bot deployed to Preview May 17, 2023 09:39 View deployment

olivermrbl merged commit a91987f into develop May 17, 2023

olivermrbl deleted the feat/remove-sqlite-support branch May 17, 2023 10:13

github-actions bot mentioned this pull request May 17, 2023

Version Packages #4114

Merged

github-actions bot mentioned this pull request May 24, 2023

Version Packages olivermrbl/medusa#42

Closed

tgdn mentioned this pull request May 25, 2023

SQLITE Error when running medusa migrations run on newly project #3833

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(medusa): Remove sqlite support #4026

feat(medusa): Remove sqlite support #4026

olivermrbl commented May 5, 2023 •

edited

Loading

changeset-bot bot commented May 5, 2023 •

edited

Loading

vercel bot commented May 5, 2023 •

edited

Loading

olivermrbl commented May 7, 2023

olivermrbl May 7, 2023 •

edited

Loading

adrien2p May 17, 2023

olivermrbl May 8, 2023

adrien2p May 17, 2023

spacewalkingninja commented May 9, 2023 •

edited

Loading

olivermrbl commented May 11, 2023

olivermrbl commented May 11, 2023

github-actions bot commented May 11, 2023

spacewalkingninja commented May 11, 2023

pKorsholm left a comment

riqwan left a comment

olivermrbl commented May 16, 2023

olivermrbl commented May 16, 2023 •

edited

Loading

riqwan left a comment

adrien2p left a comment

adrien2p May 17, 2023

adrien2p May 17, 2023

adrien2p left a comment

feat(medusa): Remove sqlite support #4026

feat(medusa): Remove sqlite support #4026

Conversation

olivermrbl commented May 5, 2023 • edited Loading

changeset-bot bot commented May 5, 2023 • edited Loading

🦋 Changeset detected

vercel bot commented May 5, 2023 • edited Loading

olivermrbl commented May 7, 2023

olivermrbl May 7, 2023 • edited Loading

Choose a reason for hiding this comment

adrien2p May 17, 2023

Choose a reason for hiding this comment

olivermrbl May 8, 2023

Choose a reason for hiding this comment

adrien2p May 17, 2023

Choose a reason for hiding this comment

spacewalkingninja commented May 9, 2023 • edited Loading

olivermrbl commented May 11, 2023

olivermrbl commented May 11, 2023

github-actions bot commented May 11, 2023

🚀 A snapshot release has been made for this PR

spacewalkingninja commented May 11, 2023

pKorsholm left a comment

Choose a reason for hiding this comment

riqwan left a comment

Choose a reason for hiding this comment

olivermrbl commented May 16, 2023

olivermrbl commented May 16, 2023 • edited Loading

riqwan left a comment

Choose a reason for hiding this comment

adrien2p left a comment

Choose a reason for hiding this comment

adrien2p May 17, 2023

Choose a reason for hiding this comment

adrien2p May 17, 2023

Choose a reason for hiding this comment

adrien2p left a comment

Choose a reason for hiding this comment

olivermrbl commented May 5, 2023 •

edited

Loading

changeset-bot bot commented May 5, 2023 •

edited

Loading

vercel bot commented May 5, 2023 •

edited

Loading

olivermrbl May 7, 2023 •

edited

Loading

spacewalkingninja commented May 9, 2023 •

edited

Loading

olivermrbl commented May 16, 2023 •

edited

Loading