Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(medusa): Expose ioredis options #4073

Merged
merged 3 commits into from
May 15, 2023
Merged

Conversation

olivermrbl
Copy link
Contributor

Why
Providers might require a specific configuration to establish a connection e.g. Heroku's latest Redis update

@olivermrbl olivermrbl requested a review from a team as a code owner May 11, 2023 08:42
@changeset-bot
Copy link

changeset-bot bot commented May 11, 2023

🦋 Changeset detected

Latest commit: 58b05f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@medusajs/medusa Patch
@medusajs/types Patch
@medusajs/admin-ui Patch
@medusajs/admin Patch
@medusajs/medusa-js Patch
medusa-payment-paypal Patch
medusa-payment-stripe Patch
medusa-plugin-restock-notification Patch
medusa-react Patch
@medusajs/medusa-oas-cli Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/event-bus-local Patch
@medusajs/event-bus-redis Patch
@medusajs/inventory Patch
medusa-plugin-algolia Patch
@medusajs/modules-sdk Patch
@medusajs/stock-location Patch
@medusajs/oas-github-ci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 4:19pm

@olivermrbl olivermrbl requested a review from adrien2p May 15, 2023 16:17
@olivermrbl
Copy link
Contributor Author

@adrien2p can you take a look at this one when you have time? Minor changes, but required for some Heroku Redis users very soon.

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks looks good to me. This instance is only used for the user sessions right?

@olivermrbl
Copy link
Contributor Author

olivermrbl commented May 15, 2023

This instance is only used for the user sessions right?

Yep!

@olivermrbl olivermrbl merged commit a86f0e8 into develop May 15, 2023
@olivermrbl olivermrbl deleted the chore/expose-redis-options branch May 15, 2023 16:56
@github-actions github-actions bot mentioned this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants