feat: Remote Joiner #4098
feat: Remote Joiner #4098
Conversation
🦋 Changeset detectedLatest commit: a432608 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Very nice piece of work man :)
I have one general thought:
Since we are adding another deps to the utils package (graphql) I think we should consider creating separated packages such as
- utils
- typeorm
- graphql
The utils should not have any restricting dependencies (typeorm, awilix, graphql) and the other packages can include the types and utils that depend on those dependencies and are very tight. wdyt?
There was a problem hiding this comment.
thought(non-blocking): Would it make sense to have the remote joiner live in its own package? Otherwise, we are bloating the bundle size of @medusajs/utils with graphql and ultimately the @medusajs/modules-sdk which is used to initialize modules.
I realise the package is not huge, but with the Edge Runtime limitations in mind + all the other stuff we'll be adding, even small packages make a difference.
Update: I see @adrien2p has commented on something related already. Let's discuss early next week :)
|
Also, this is an insane piece of work @carlos-r-l-rodrigues 🚀 |
carlos-r-l-rodrigues
force-pushed
the
feat/remote-joiner
branch
from
46b8f3c to
f157a3f
Compare
|
@adrien2p - wdyt, ready to merge? |
Remote Joiner