feat(admin-ui): Rename allocation to reservation #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 376537f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
pKorsholm
changed the title
olivermrbl
changed the title
pKorsholm
force-pushed
the
feat/rename-allocation-to-discount
branch
from
aa6c92d to
3ace14a
Compare
olivermrbl
approved these changes
May 25, 2023
| variant={allItemsReserved ? "success" : "danger"} | ||
| title={allItemsReserved ? "Allocated" : "Awaits allocation"} | ||
| title={allItemsReserved ? "Allocated" : "Not fully reserved"} |
There was a problem hiding this comment.
comment: Think we can keep the allocation notion here to have consistent wording in the two possible states:
Not fully allocated / Partially allocated
| } | ||
| variant={allItemsReserved || !isAllocatable ? "success" : "danger"} | ||
| title={ | ||
| allItemsReserved || !isAllocatable | ||
| ? "Allocated" | ||
| : "Awaits allocation" | ||
| : "Not fully reserved" |
There was a problem hiding this comment.
comment: See other comment
|
Feel free to merge after addressing the comments @pKorsholm :) |
olivermrbl
pushed a commit
that referenced
this pull request
Jun 14, 2023
* rename allocation -> reservation * add changeset * edit-reservation modal * rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CORE-1380