Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(admin-ui): Ensure that default invite link uses __BASE__ if set #4173

Merged
merged 2 commits into from
May 25, 2023
Merged

fix(admin-ui): Ensure that default invite link uses __BASE__ if set #4173

merged 2 commits into from
May 25, 2023

Conversation

kasperkristensen
Copy link
Contributor

What

  • If the BASE is set, which is the case if serving the admin on the server, make sure that the default invite link includes the base in the generated link.

@kasperkristensen kasperkristensen requested a review from a team as a code owner May 25, 2023 09:36
@changeset-bot
Copy link

changeset-bot bot commented May 25, 2023

🦋 Changeset detected

Latest commit: c702d09

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/admin-ui Patch
@medusajs/admin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) May 25, 2023 9:36am

olivermrbl
olivermrbl approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olivermrbl olivermrbl merged commit 9a46c11 into develop May 25, 2023
@github-actions github-actions bot mentioned this pull request May 25, 2023
Merged
@kasperkristensen kasperkristensen linked an issue May 26, 2023 that may be closed by this pull request
Bug: Team user invite link is incorrect #4182
Closed
@kasperkristensen kasperkristensen mentioned this pull request May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Team user invite link is incorrect
2 participants
@kasperkristensen @olivermrbl