Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(medusa): downgrade papaparse version #4174

Merged
merged 2 commits into from
May 25, 2023
Merged

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented May 25, 2023

What

  • latest minor version bump of the library is causing several issues while importing a CSV file - fixing the version to 5.3.2 seems to fix the issues
  • more readable formatting of error message
  • add types

@changeset-bot
Copy link

changeset-bot bot commented May 25, 2023

🦋 Changeset detected

Latest commit: 503151c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@medusajs/medusa Patch
@medusajs/admin-ui Patch
@medusajs/admin Patch
@medusajs/medusa-js Patch
medusa-payment-paypal Patch
medusa-payment-stripe Patch
medusa-plugin-restock-notification Patch
medusa-react Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) May 25, 2023 10:38am

@raukaute
Copy link

@fPolic

Can you add some information on the several issues this commit fixes?

@fPolic fPolic linked an issue May 25, 2023 that may be closed by this pull request
@fPolic fPolic marked this pull request as ready for review May 25, 2023 13:21
@fPolic fPolic requested a review from a team as a code owner May 25, 2023 13:21
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪 do you have an idea of which issues it is fixing so far? was it a breaking changes on their side? Should we warn them?

@olivermrbl
Copy link
Contributor

@fPolic merging - will you get back on the comments? :)

@olivermrbl olivermrbl merged commit 92f01ce into develop May 25, 2023
@olivermrbl olivermrbl deleted the fix/broken-csv-parsing branch May 25, 2023 18:27
@github-actions github-actions bot mentioned this pull request May 25, 2023
@fPolic
Copy link
Contributor Author

fPolic commented May 29, 2023

LGTM 💪 do you have an idea of which issues it is fixing so far? was it a breaking changes on their side? Should we warn them?

@adrien2p There were different errors reported depending on the input file but all were a result of broken parsing, also the issue with appended _{index} values instead of null is fixed by this PR.
There has been a couple of similar reports on their GitHub page so they are aware of the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product import bugs
4 participants