Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(medusa-fulfillment-manual): Missing retrieveDocuments override #4221

Merged

Conversation

josipmatichr
Copy link
Contributor

retrieveDocuments should be overridden in the child class

@josipmatichr josipmatichr requested a review from a team as a code owner May 31, 2023 09:08
@changeset-bot
Copy link

changeset-bot bot commented May 31, 2023

🦋 Changeset detected

Latest commit: ee60ae4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
medusa-fulfillment-manual Patch
@medusajs/medusa Patch
@medusajs/admin-ui Patch
@medusajs/admin Patch
@medusajs/medusa-js Patch
medusa-payment-paypal Patch
medusa-payment-stripe Patch
medusa-plugin-mailchimp Patch
medusa-plugin-restock-notification Patch
medusa-react Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 31, 2023

@josipmatichr is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@josipmatichr josipmatichr changed the title adds missing retrieveDocuments override fix(medusa-fulfillment-manual): Missing retrieveDocuments override May 31, 2023
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks 💪

@vercel
Copy link

vercel bot commented May 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) May 31, 2023 10:40am

@olivermrbl olivermrbl merged commit 1090964 into medusajs:develop Jun 5, 2023
@github-actions github-actions bot mentioned this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants