Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-ui): flickering Timeline #4231

Merged
merged 4 commits into from
Jun 7, 2023
Merged

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Jun 1, 2023

What

  • Timeline component is "jumpy" during initial load due to async loading of data required for rendering

How

  • await all relevant data fetching to finish before returning data from useBuildTimelineEvents
  • use order edit from event instead of re-fetching

FIXES CORE-1382

@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2023

🦋 Changeset detected

Latest commit: c11ad0b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/admin-ui Patch
@medusajs/admin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 9:29am

@fPolic fPolic marked this pull request as ready for review June 6, 2023 09:24
@fPolic fPolic requested a review from a team as a code owner June 6, 2023 09:24
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olivermrbl olivermrbl merged commit 1bd2e7a into develop Jun 7, 2023
@olivermrbl olivermrbl deleted the fix/flickering-timeline branch June 7, 2023 08:58
@github-actions github-actions bot mentioned this pull request Jun 7, 2023
olivermrbl pushed a commit that referenced this pull request Jun 14, 2023
* fix(admin-ui): prevent Timeline flickering while loading

* chore: changesets

---------

Co-authored-by: fPolic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants