Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(product, types): correct path for migration files + fix types on products service module #4348

Merged
merged 5 commits into from
Jun 19, 2023
Merged

fix(product, types): correct path for migration files + fix types on products service module #4348

merged 5 commits into from
Jun 19, 2023

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Jun 19, 2023

No description provided.

@riqwan riqwan requested a review from a team as a code owner June 19, 2023 09:38
@vercel
Copy link

vercel bot commented Jun 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Jun 19, 2023 1:24pm

@changeset-bot
Copy link

changeset-bot bot commented Jun 19, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 36e5e61

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@medusajs/product Patch
@medusajs/types Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@riqwan riqwan changed the title chore: correct path for migration files fix(product): correct path for migration files Jun 19, 2023
@riqwan
Copy link
Contributor Author

riqwan commented Jun 19, 2023

/snapshot-this

@riqwan riqwan force-pushed the feat/migration-fix branch from 0682aa9 to 4c726ec Compare June 19, 2023 10:05
@shahednasser
Copy link
Member

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshot by updating your package.json with the newly published version:

yarn add @medusajs/[email protected]

Latest commit: bf4f5e7

@riqwan riqwan force-pushed the feat/migration-fix branch from ed0ea74 to cec51c7 Compare June 19, 2023 12:06
@riqwan riqwan force-pushed the feat/migration-fix branch from cec51c7 to 7d8b919 Compare June 19, 2023 12:08
carlos-r-l-rodrigues
carlos-r-l-rodrigues approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

we can remove - import { Utils } from "@mikro-orm/core"

@olivermrbl
Copy link
Contributor

/snapshot-this

@riqwan
Copy link
Contributor Author

riqwan commented Jun 19, 2023

@carlos-r-l-rodrigues removed, I've added some type fixes in as well that I came across.

@olivermrbl
Copy link
Contributor

removed, I've added some type fixes in as well that I came across

should be reflected in the changeset 👍

@riqwan
Copy link
Contributor Author

riqwan commented Jun 19, 2023

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshot by updating your package.json with the newly published version:

yarn add @medusajs/[email protected]

Latest commit: bf4f5e7

@riqwan riqwan force-pushed the feat/migration-fix branch from ca27517 to 8c030c3 Compare June 19, 2023 13:23
@riqwan riqwan force-pushed the feat/migration-fix branch from 8c030c3 to 36e5e61 Compare June 19, 2023 13:24
@olivermrbl
Copy link
Contributor

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]

Latest commit: bf4f5e7

@riqwan riqwan changed the title fix(product): correct path for migration files fix(product, types): correct path for migration files + fix types on products service module Jun 19, 2023
olivermrbl
olivermrbl approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olivermrbl olivermrbl merged commit dc12012 into develop Jun 19, 2023
@olivermrbl olivermrbl deleted the feat/migration-fix branch June 19, 2023 14:12
@github-actions github-actions bot mentioned this pull request Jun 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@olivermrbl olivermrbl olivermrbl approved these changes

@adrien2p adrien2p Awaiting requested review from adrien2p

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@riqwan @shahednasser @olivermrbl @carlos-r-l-rodrigues