Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(create-medusa-app): Cleanup the main script for readability and maintanability #4369

Merged
merged 6 commits into from
Jul 10, 2023

Conversation

adrien2p
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2023

🦋 Changeset detected

Latest commit: 2b6eb62

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-medusa-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2023 3:27pm

@adrien2p adrien2p force-pushed the chore/cleanup-medusa-create branch from 2b32944 to a711960 Compare June 20, 2023 15:00
@adrien2p adrien2p marked this pull request as ready for review June 22, 2023 09:28
@adrien2p adrien2p requested a review from a team as a code owner June 22, 2023 09:28
@adrien2p adrien2p requested a review from olivermrbl June 22, 2023 09:29
@olivermrbl olivermrbl requested a review from shahednasser June 29, 2023 11:47
@shahednasser
Copy link
Member

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]

Latest commit: 6c3eeb8

Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @adrien2p 🙏🏻

@olivermrbl olivermrbl merged commit d363da2 into develop Jul 10, 2023
@olivermrbl olivermrbl deleted the chore/cleanup-medusa-create branch July 10, 2023 14:27
This was referenced Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants