fix(medusa, utils): fix the way selects are consumed alongside the relations #4389
Conversation
🦋 Changeset detectedLatest commit: ba17e8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshot by updating your yarn add @medusajs/[email protected]
|
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/[email protected]yarn add @medusajs/[email protected]yarn add @medusajs/[email protected]
|
|
@olivermrbl I had to re introduce the |
done, what do you think? |
|
@olivermrbl wdyt? |
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/[email protected]yarn add @medusajs/[email protected]yarn add @medusajs/[email protected]yarn add @medusajs/[email protected]yarn add [email protected]yarn add @medusajs/[email protected]yarn add @medusajs/[email protected]yarn add [email protected]yarn add @medusajs/[email protected]yarn add [email protected]yarn add [email protected]yarn add [email protected]yarn add [email protected]yarn add [email protected]yarn add [email protected]yarn add [email protected]yarn add @medusajs/[email protected]yarn add @medusajs/[email protected]yarn add @medusajs/[email protected]yarn add @medusajs/[email protected]
|
What
There is actually an issue with using the
fieldsquery params with the way the repositories are using our custom query strategy. This pr aims to fix this issue by reworking the strategy.What we had to do was to rework the way the selects are built for each subquery in order to follow the aliasing convention and to be taken into consideration. Alongside these changes, the join used to always select everything, this needed to be changed so that if there are any selects provided for a join, the join should not select everything and let the query select the fields that are requested.
Another notable change is that all the repositories are now using the repository util in order to centralize the customization and to have a single place to update when this kind of issue arises. This means that the eager relations when using the query builder are not necessarily taken into account. For that reason, I have removed the
shipping_optioneager option in favor of explicitly asking for the relations like we started to do it in some places.FIXES CORE-1413