Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(medusa, stripe, paypal): Add update payment session support to the abstract payment processor API #4442

Merged
merged 10 commits into from
Jul 10, 2023
Merged

feat(medusa, stripe, paypal): Add update payment session support to the abstract payment processor API #4442

merged 10 commits into from
Jul 10, 2023

Conversation

adrien2p
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jun 30, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 33a2933

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@medusajs/medusa Patch
medusa-payment-paypal Patch
medusa-payment-stripe Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Jul 10, 2023 11:52am

This was referenced Jul 3, 2023
Closed
Closed
@adrien2p adrien2p marked this pull request as ready for review July 3, 2023 09:38
@adrien2p adrien2p requested a review from a team as a code owner July 3, 2023 09:38
olivermrbl
olivermrbl approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just reaching out to issue reporters for a test run before we merge :)

@olivermrbl olivermrbl merged commit 4264302 into develop Jul 10, 2023
@olivermrbl olivermrbl deleted the feat/update-payment-session branch July 10, 2023 13:59
@github-actions github-actions bot mentioned this pull request Jul 10, 2023
Merged
@ripvannwinkler
Copy link

I'm no longer knee deep in that part of the code, but I can rework it a bit to give it a test.

@olivermrbl
Copy link
Contributor

/snapshot-this

@olivermrbl
Copy link
Contributor

@ripvannwinkler – that would be super helpful!

@olivermrbl
Copy link
Contributor

If you have the time, you can test with these versions:

[email protected]
@medusajs/[email protected]

This was referenced Jul 11, 2023
Closed
Merged
@lrocher91
Copy link

lrocher91 commented Jul 19, 2023 •
edited
Loading

Can you provide a version for medusa-payment-paypal too ?
Not using stripe atm but the fix in @medusajs/[email protected] seems ok

Dont saw you released [email protected]. Working as expected now, maybe you can close #4166

@olivermrbl olivermrbl mentioned this pull request Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@riqwan riqwan Awaiting requested review from riqwan

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrien2p @ripvannwinkler @olivermrbl @lrocher91