Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types, product): added product module update #4504

Merged
merged 95 commits into from
Jul 26, 2023
Merged

feat(types, product): added product module update #4504

merged 95 commits into from
Jul 26, 2023

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Jul 11, 2023 •
edited
Loading

What:

  • Adds update method to product module service, product service and repository
    • this cascades to collections, categories and variants
  • Align retrieve method with other services

RESOLVES CORE-1435

adrien2p added 30 commits July 3, 2023 10:59
@adrien2p
Feat: create product with product module
a3fb9e4
@adrien2p
feat: create product wip
9a187d2
@adrien2p
feat: create product wip
0448539
@adrien2p
feat: update product relation and generate image migration
57572e6
@adrien2p
lint
72a9335
@adrien2p
conitnue implementation
6288d74
@adrien2p
continue implementation and add integration tests for produceService.…
6f96f2e 
…create
@adrien2p
Add integration tests for product creation at the module level for th…
50b6f96 
…e complete flow
@adrien2p
only use persist since write operations are always wrapped in a trans…
47173af 
…action which will be committed and flushed
@adrien2p
simplify the transaction wrapper to make future changes easier
010bc79
@adrien2p
feat: move some utils to the utils package to simplify its usage
1cc8115
@adrien2p
tests: fix unit tests
fc71428
@adrien2p
feat: create variants along side the product
a802895
@adrien2p
Add more integration tests an update migrations
0dab759
@adrien2p
Merge branch 'develop' into feat/product-module-create
89b7eed
@adrien2p
chore: Update actions workflow to include packages integration tests
8da124b
@adrien2p
small types and utils cleanup
7c63417
@adrien2p
chore: Add support for database debug option
0760311
@adrien2p
chore: Add missing types in package.json from types and util, validat…
b0cb6c8 
…e that all the models are sync with medusa
@adrien2p
expose retrieve method
d00e357
@adrien2p
fix types issues
e0f3a25
@adrien2p
fix unit tests and move integration tests workflow with the plugins i…
9a51010 
…ntegration tests
@adrien2p
chore: remove migration function export from the definition to preven…
b203071 
…t them to be ran by the medusa cli just in case
@adrien2p
fix package.json script
ddb5620
@adrien2p
chore: workflows
e45402d
@adrien2p
feat: start creating the create product workflow
4b410b1
@adrien2p
feat: add empty step for prices and sales channel
f20cccc
@adrien2p
tests: update scripts and action envs
09bec65
@adrien2p
fix imports
01b23b9
@adrien2p
feat: Add proper soft deleted support + add product deletion service …
87616c7 
…public api
@riqwan riqwan force-pushed the feat/product-module-update branch from 3d141ba to dbc7dd2 Compare July 18, 2023 07:55
@riqwan riqwan requested review from adrien2p and olivermrbl July 18, 2023 07:56
@riqwan riqwan changed the base branch from feat/product-module-create to develop July 18, 2023 10:50
@riqwan riqwan changed the base branch from develop to feat/product-module-create July 18, 2023 10:50
@riqwan riqwan changed the base branch from feat/product-module-create to develop July 18, 2023 10:51
@riqwan riqwan changed the title feat(types, medusa): added product module update feat(types, product): added product module update Jul 26, 2023
adrien2p
adrien2p approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one last comment :)

olivermrbl
olivermrbl approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work @riqwan !! 🚢

@riqwan riqwan merged commit caea44e into develop Jul 26, 2023
@riqwan riqwan deleted the feat/product-module-update branch July 26, 2023 13:18
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p approved these changes

@olivermrbl olivermrbl olivermrbl approved these changes

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@riqwan @olivermrbl @adrien2p @carlos-r-l-rodrigues