Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(medusa): Return correct region count #4514

Merged
merged 6 commits into from
Jul 13, 2023
Merged

Fix(medusa): Return correct region count #4514

merged 6 commits into from
Jul 13, 2023

Conversation

pKorsholm
Copy link
Contributor

What

  • create listAndCount method for region service
  • return total count of regions in list-regions endpoint

Why

  • Pagination of regions in order filters didn't work since limit would equal count since we always returned count as regions.length

Fixes CORE-1433

@pKorsholm pKorsholm requested a review from a team as a code owner July 12, 2023 13:21
@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: f13b5dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jul 13, 2023 6:43am

olivermrbl
olivermrbl approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor todo

srindom
srindom approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pKorsholm pKorsholm merged commit 56d1d32 into develop Jul 13, 2023
This was referenced Jul 13, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srindom srindom srindom approved these changes

@olivermrbl olivermrbl olivermrbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pKorsholm @srindom @olivermrbl