Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(medusa-file-minio): Minio private bucket default #4540

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

pKorsholm
Copy link
Contributor

What

  • default getUploadDescriptor to use private bucket, similar to aws and digital ocean

closes #4539

@pKorsholm pKorsholm requested a review from a team as a code owner July 17, 2023 07:11
@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2023

🦋 Changeset detected

Latest commit: 488733a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
medusa-file-minio Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Jul 17, 2023 7:11am

@pKorsholm pKorsholm requested review from adrien2p and olivermrbl July 17, 2023 07:12
@olivermrbl olivermrbl changed the title Fix(medusa-file-minio): Minio private bucket default fix(medusa-file-minio): Minio private bucket default Jul 17, 2023
@pKorsholm pKorsholm merged commit 950a581 into develop Jul 17, 2023
This was referenced Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export product uploaded to public bucket when using minio
2 participants