Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(product): Serialize typings #4602

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Jul 25, 2023

What:
Fix the serializer

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2023

🦋 Changeset detected

Latest commit: e85ec4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@medusajs/product Patch
@medusajs/types Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 7:37am

@adrien2p adrien2p marked this pull request as ready for review July 25, 2023 10:50
@adrien2p adrien2p requested a review from a team as a code owner July 25, 2023 10:50
@olivermrbl
Copy link
Contributor

Why are these updated?

@adrien2p
Copy link
Member Author

Why are these updated?

To fix the serializer

@adrien2p adrien2p requested a review from olivermrbl July 25, 2023 13:01
@olivermrbl
Copy link
Contributor

To fix the serializer

Yes, I see that it fixes the serializer, but what was wrong? 😅

@adrien2p
Copy link
Member Author

To fix the serializer

Yes, I see that it fixes the serializer, but what was wrong? 😅

The return value was wrong, if it wasn't an array it was returning undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants