fix(module-sdk): Shared modules loading #4611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7b1919b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I have tested on @pKorsholm pr and it works with all the module being shared, which wasn't working previously |
adrien2p
requested review from
riqwan,
carlos-r-l-rodrigues,
olivermrbl and
pKorsholm
olivermrbl
approved these changes
Jul 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Makes the modules container completely isolated no matter the
resourcesmodule declaration. Register in the isolated container all the dependencies that are required by the modules and always includemanagerandconfigModulewhen the resources are set toshared.The shared resources should only share the mutualized manager and config module, it makes no sense that the module shares the entire container from the core and should be prevented as it can lead to unintentional behaviors and circumvent the purpose of a module which is to isolate a domain or a feature. Also, if something needs to be shared, it can be passed as a dependency through the configuration. This was also the intention first behind the implementation of the shared concept.
Also, now the product module can be shared if needed in the future (shared knex/driver connection reused by the internal ORM). The module does not export the models since we don't want the internal module models to be shared with the medusa package, nor the migrations.