chore: include rimraf as part of the build for most of the packages #4615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
@olivermrbl I am not sure but I don't think we should include a changeset here right? |
|
No this doesn't need one 👍 |
olivermrbl
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
At the moment, in most packages, when we run the build script after removing something or changing pr, the dist directory does not get cleaned up and might still contain your old files. In those cases, if you don't pay attention, you might end up having weird behaviors and errors that might take sometimes before thinking about removing the dist and re-building. This pr add rimraf in most of the packages where it was missing as well as updated the build commands to include rimraf of the dist directory to prevent this situation.