Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(medusa): Update request-ip dependency version #4636

Merged

Conversation

pevey
Copy link
Contributor

@pevey pevey commented Jul 29, 2023

This updates the request-ip package dependency in @medusajs/medusa.

This resolves the critical security warnings seen when creating a new medusa backend OTHER THAN medusa-admin related issues. Because the admin is undergoing an extensive rewrite, I didn't address the older version of node-fetch that is at the root of those issues.

@pevey pevey requested a review from a team as a code owner July 29, 2023 18:55
@changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2023

🦋 Changeset detected

Latest commit: 896f038

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 29, 2023

@pevey is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@olivermrbl olivermrbl changed the title update request-ip dependency version chore(medusa): Update request-ip dependency version Jul 31, 2023
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @pevey !

@olivermrbl
Copy link
Contributor

@pevey can I get you to resolve conflicts, so we can merge? 🙏

@pevey
Copy link
Contributor Author

pevey commented Aug 2, 2023

I'm not sure I have permission to push a new lockfile. I'll give it a try.

@pevey
Copy link
Contributor Author

pevey commented Aug 2, 2023

It looks like the lock file in the branch has been added, but it may not be up to date now with the develop branch. It don't believe I have permission to resolve the conflict. Or maybe you could point me in the right direction.

Screenshot:
Screenshot 2023-08-02 070727

@olivermrbl
Copy link
Contributor

olivermrbl commented Aug 2, 2023

If you sync your fork with the latest changes from develop, you should be able to merge that into this branch and resolve the conflict

Let me know if it doesn't work, then I can investigate

Nevermind, I will attend to it! :)

@vercel
Copy link

vercel bot commented Aug 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 2:54pm

@kodiakhq kodiakhq bot merged commit 9c682ce into medusajs:develop Aug 2, 2023
@github-actions github-actions bot mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants