feat(modules-sdk,link-modules,orchestration,inventory,product,stock-location): link modules #4637

carlos-r-l-rodrigues · 2023-07-30T13:54:07Z

What:
Default package containing all Medusa's link modules definition and manage the creation of pre-defined or custom links.

import { initialize as iniInventory } from "@medusajs/inventory";
import { initialize as iniProduct } from "@medusajs/product";

import {
  initialize as iniLinks,
  runMigrations as migrateLinks
} from "@medusajs/link-modules";

await Promise.all([iniInventory(), iniProduct()]);


await migrateLinks(); // create tables based on previous loaded modules

await iniLinks(); // load link based on previous loaded modules

await iniLinks(undefined, [
  {
    serviceName: "product_custom_translation_service_link",
    isLink: true,
    tableName: "product_transalations",
    alias: [
      {
        name: "translations",
      },
    ],
    primaryKeys: ["id", "product_id", "translation_id"],
    relationships: [
      {
        serviceName: Modules.PRODUCT,
        primaryKey: "id",
        foreignKey: "product_id",
        alias: "product",
      },
      {
        serviceName: "custom_translation_service",
        primaryKey: "id",
        foreignKey: "translation_id",
        alias: "transalation",
        deleteCascade: true,
      },
    ],
    extends: [
      {
        serviceName: Modules.PRODUCT,
        relationship: {
          serviceName: "product_custom_translation_service_link",
          primaryKey: "product_id",
          foreignKey: "id",
          alias: "translations",
          isList: true,
        },
      },
      {
        serviceName: "custom_translation_service",
        relationship: {
          serviceName: "product_custom_translation_service_link",
          primaryKey: "product_id",
          foreignKey: "id",
          alias: "product_link",
        },
      },
    ],
  },
]); // custom links

…elop

…t/link-modules

changeset-bot · 2023-07-30T13:54:10Z

🦋 Changeset detected

Latest commit: 25a9edc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages

Name	Type
@medusajs/stock-location	Minor
@medusajs/orchestration	Minor
@medusajs/link-modules	Minor
@medusajs/modules-sdk	Minor
@medusajs/inventory	Minor
@medusajs/product	Minor
@medusajs/medusa	Minor
@medusajs/types	Minor
@medusajs/utils	Minor
@medusajs/workflows	Patch
@medusajs/medusa-oas-cli	Patch
@medusajs/oas-github-ci	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2023-07-30T13:54:11Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
medusa-docs	⬜️ Ignored (Inspect)	Visit Preview		Jul 31, 2023 1:00am

…into feat/link-modules

adrien2p

😂 I am stopping the review here as I just saw that it wasn't ready sorry man. Let's huddle if needed

adrien2p · 2023-07-31T08:43:12Z

packages/link-modules/package.json

+  },
+  "dependencies": {
+    "@medusajs/modules-sdk": "^1.8.8",
+    "@medusajs/types": "^1.8.11",


todo: dev deps

adrien2p · 2023-07-31T08:44:43Z

packages/link-modules/src/definitions/product-variant-inventory-item.ts

+    {
+      name: "product_variant_inventory_item",
+    },
+    {
+      name: "product_variant_inventory_items",
+    },


todo: duplicate

adrien2p · 2023-07-31T08:47:09Z

packages/link-modules/src/definitions/product-variant-inventory-item.ts

+      serviceName: Modules.PRODUCT,
+      primaryKey: "id",
+      foreignKey: "variant_id",
+      alias: "variant",
+      args: {
+        methodSuffix: "Variants",
+      },


todo: shouldn't it be a list of variants on which we retrieve and attach the inventory item?

adrien2p · 2023-07-31T08:49:07Z

packages/link-modules/src/initialize/index.ts

+import { getLoaders } from "../loaders"
+import { getMigration } from "../migration"
+
+type ILinkModule = {}


todo: we should change that no?

adrien2p · 2023-07-31T08:50:07Z

packages/link-modules/src/initialize/index.ts

+
+    if (definition.relationships?.length !== 2 && !definition.isReadOnlyLink) {
+      throw new Error(
+        `Link module ${definition.serviceName} must have 2 relationships.`


question: shouldn't it be at least and not strict? unless it has 2 relationships and then the rest is just the extends?

adrien2p · 2023-07-31T09:09:44Z

packages/link-modules/src/services/link-module-service.ts

+    config: FindConfig<unknown> = {},
+    sharedContext?: Context
+  ): Promise<[ProductTypes.ProductDTO[], number]> {
+    const [products, count] = await this.pivotService_.listAndCount(


todo: rename the const to something more generic

adrien2p · 2023-07-31T09:10:55Z

packages/link-modules/src/services/link-module-service.ts

+  }
+
+  @InjectTransactionManager(shouldForceTransaction, "baseRepository_")
+  async create(data: unknown[], @MedusaContext() sharedContext: Context = {}) {


todo: create a protected method such as create_ that is wrapped in a transaction and call it here, then call the serialize from the base repository on the result. Otherwise here we are returning a mikro orm object

adrien2p · 2023-07-31T09:11:51Z

packages/link-modules/src/services/link-module-service.ts

+    productIds: string[],
+    @MedusaContext() sharedContext: Context = {}
+  ): Promise<TPivot[]> {
+    return await this.pivotService_.softDelete(productIds, sharedContext)


todo: same as previous

adrien2p · 2023-07-31T09:12:06Z

packages/link-modules/src/services/link-module-service.ts

+    productIds: string[],
+    @MedusaContext() sharedContext: Context = {}
+  ): Promise<TPivot[]> {
+    return await this.pivotService_.restore(productIds, sharedContext)


todo: sam as previous

adrien2p · 2023-07-31T09:12:26Z

packages/link-modules/src/services/pivot.ts

@@ -0,0 +1,97 @@
+import { Context, DAL, FindConfig } from "@medusajs/types"


todo: this file, missing all the decorators

carlos-r-l-rodrigues added 14 commits July 4, 2023 13:29

Merge branch 'develop' of https://github.com/medusajs/medusa into dev…

35adfa4

…elop

Merge branch 'develop' of https://github.com/medusajs/medusa into dev…

7948d29

…elop

Merge branch 'develop' of https://github.com/medusajs/medusa into dev…

547b97d

…elop

Merge branch 'develop' of https://github.com/medusajs/medusa into dev…

963f549

…elop

Merge branch 'develop' of https://github.com/medusajs/medusa into dev…

c9aeca0

…elop

Merge branch 'develop' of https://github.com/medusajs/medusa into dev…

926d87e

…elop

initial commit

39968b9

Merge branch 'develop' of https://github.com/medusajs/medusa into fea…

3eae802

…t/link-modules

chore: wip

af841db

chore: generate entity and migration

908c471

chore: entity index

31c4f67

fix: remote joiner isList

d7b5879

chore: read only link definition

0b90038

chore: MedusaModule.bootstrapLink

4f155a6

carlos-r-l-rodrigues and others added 5 commits July 30, 2023 11:16

wip: --passWithNoTests

4ef0069

wip: remove unused packages

dd0ef1a

changeset

23c8a81

Merge branch 'develop' into feat/link-modules

b916bb4

Merge branch 'feat/link-modules' of https://github.com/medusajs/medusa …

46fc041

…into feat/link-modules

vercel bot deployed to Preview July 30, 2023 15:25 View deployment

carlos-r-l-rodrigues added 2 commits July 30, 2023 20:44

rem tests

1444629

jest config

25a9edc

adrien2p reviewed Jul 31, 2023

View reviewed changes

carlos-r-l-rodrigues closed this Jul 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(modules-sdk,link-modules,orchestration,inventory,product,stock-location): link modules #4637

feat(modules-sdk,link-modules,orchestration,inventory,product,stock-location): link modules #4637

carlos-r-l-rodrigues commented Jul 30, 2023

changeset-bot bot commented Jul 30, 2023 •

edited

Loading

vercel bot commented Jul 30, 2023 •

edited

Loading

adrien2p left a comment •

edited

Loading

adrien2p Jul 31, 2023

adrien2p Jul 31, 2023

adrien2p Jul 31, 2023

adrien2p Jul 31, 2023

adrien2p Jul 31, 2023

adrien2p Jul 31, 2023

adrien2p Jul 31, 2023

adrien2p Jul 31, 2023

adrien2p Jul 31, 2023

adrien2p Jul 31, 2023

		@@ -0,0 +1,97 @@
		import { Context, DAL, FindConfig } from "@medusajs/types"

feat(modules-sdk,link-modules,orchestration,inventory,product,stock-location): link modules #4637

feat(modules-sdk,link-modules,orchestration,inventory,product,stock-location): link modules #4637

Conversation

carlos-r-l-rodrigues commented Jul 30, 2023

changeset-bot bot commented Jul 30, 2023 • edited Loading

🦋 Changeset detected

vercel bot commented Jul 30, 2023 • edited Loading

adrien2p left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

changeset-bot bot commented Jul 30, 2023 •

edited

Loading

vercel bot commented Jul 30, 2023 •

edited

Loading

adrien2p left a comment •

edited

Loading