Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflows): Improve typings #4689

Merged
merged 5 commits into from
Aug 4, 2023
Merged

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Aug 3, 2023

Just improve some typings for simpler usage

@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2023

🦋 Changeset detected

Latest commit: b5478fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/workflows Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 4, 2023 7:54am

Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lessgooo!

@adrien2p adrien2p marked this pull request as ready for review August 3, 2023 15:18
@adrien2p adrien2p requested a review from a team as a code owner August 3, 2023 15:18
@adrien2p
Copy link
Member Author

adrien2p commented Aug 3, 2023

@olivermrbl @carlos-r-l-rodrigues if i could get your review please 😊

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

small comment

@kodiakhq kodiakhq bot merged commit 43f3486 into develop Aug 4, 2023
@kodiakhq kodiakhq bot deleted the feat/improve-worklow-pipe-typings branch August 4, 2023 08:11
@github-actions github-actions bot mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants