Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa): Allow logging to file #4696

Merged
merged 4 commits into from
Aug 6, 2023

Conversation

pevey
Copy link
Contributor

@pevey pevey commented Aug 4, 2023

Small change to enable additional logger transport to file if LOG_FILE environment variable is set.

I believe this should close #4362.

Perhaps some of the Winston options could also be exposed though config, in the same way session options recently were. Let me know if you want me to add that.

@pevey pevey requested a review from a team as a code owner August 4, 2023 20:05
@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2023

🦋 Changeset detected

Latest commit: 0314f43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/medusa Patch
@medusajs/medusa-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 4, 2023

@pevey is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olivermrbl olivermrbl changed the title Feat/allow logging to file feat(medusa): Allow logging to file Aug 6, 2023
@olivermrbl olivermrbl merged commit 03fb047 into medusajs:develop Aug 6, 2023
@github-actions github-actions bot mentioned this pull request Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lack of Logging Functionality in Medusa.js: Exploring the Reasons and Alternatives
2 participants