-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(medusa, utils): Allow object feature flags #4701
Conversation
🦋 Changeset detectedLatest commit: 65bad34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
ceaae51
to
33bbbae
Compare
… into feat/feature-flag-nested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just added one thought.
packages/medusa/src/api/routes/admin/products/create-product.ts
Outdated
Show resolved
Hide resolved
@adrien2p – we should probably switch out the core flag router with the one from utils soon to not maintain several |
@olivermrbl yes definitely, i didn't thought we would change it that quickly 😅 maybe you can include it here? Or ill do it tomorrow |
Will do it in a follow up tomorrow 👍 |
150741a
to
c491dea
Compare
f14de2c
to
42a6282
Compare
@adrien2p, will you give this a review? Would like to cut a release today with the create-products endpoint guarded by this feature flag |
Yes i will @olivermrbl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 💪 few small todo's
ad87af9
to
81425ac
Compare
Feature flags can be set as follows:
Environment variables
Project config