feat(workflows):product handlers should be reusable in different context #4703
Conversation
🦋 Changeset detectedLatest commit: fb70692 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/workflows/src/handlers/product/attach-sales-channel-to-products.ts
Outdated
Show resolved
Hide resolved
adrien2p
changed the title
| @@ -1,17 +1,20 @@ | |||
| import { ProductTypes, WorkflowTypes } from "@medusajs/types" | |||
| import { WorkflowArguments } from "../../helper" | |||
|
|
|||
| type HandlerInput = { | |||
| productIds: string[] | |||
There was a problem hiding this comment.
suggestion: ids should be fine, the handler name speaks for itself
| productIds: string[] | |
| ids: string[] |
I didn't because it is the handler typing, so if the handler needs to evolve and we are having a shared type, we will quickly end up composing custom stuff on top of it. I prefer if it stays to the handler as is for now. wdyt? |
Makes sense. Let's keep it as is 👍 |
What
The listProducts handler should not be specific to the workflow.
Same for the product removal, shouldn't expect an entire DTO but just a collection of object that at least contains the id.
Same principle applied to other product handlers