Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: scope errors on workflow to invoke #4709

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Aug 7, 2023

what:

Scopes the errors from the exported workflow to return only invoke errors.

If an error occurs on the invoke level, it'll stop the invoke flow and begin the compensation flow. If another error shows up on the compensate level, it doesn't make sense to throw that error since the user won't be able to do anything about it.

@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2023

⚠️ No Changeset found

Latest commit: ebdac20

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 7, 2023 4:25pm

Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@carlos-r-l-rodrigues carlos-r-l-rodrigues marked this pull request as ready for review August 7, 2023 16:18
@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team as a code owner August 7, 2023 16:18
@riqwan riqwan requested review from adrien2p and olivermrbl August 7, 2023 16:20
@kodiakhq kodiakhq bot merged commit a42c41e into develop Aug 7, 2023
@kodiakhq kodiakhq bot deleted the chore/errors-scoping branch August 7, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants