Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed existingItems query in addOrUpdateLineItems #4714

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Fixed existingItems query in addOrUpdateLineItems #4714

merged 1 commit into from
Aug 8, 2023

Conversation

DidierGuyon
Copy link
Contributor

Fixes Issue #4713

@DidierGuyon DidierGuyon requested a review from a team as a code owner August 8, 2023 09:19
@vercel
Copy link

vercel bot commented Aug 8, 2023

@DidierGuyon is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023

⚠️ No Changeset found

Latest commit: 52837bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

adrien2p
adrien2p approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix 💪

olivermrbl
olivermrbl approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @adrien2p would be good with a test for this

@olivermrbl olivermrbl linked an issue Aug 8, 2023 that may be closed by this pull request
Cart Service - addOrUpdateLineItems - Issue when updating existing LineItems #4713
Closed
@olivermrbl olivermrbl merged commit 0cba4d6 into medusajs:develop Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p approved these changes

@olivermrbl olivermrbl olivermrbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cart Service - addOrUpdateLineItems - Issue when updating existing LineItems
3 participants
@DidierGuyon @adrien2p @olivermrbl