fix(medusa): Remove shipping on updates to cart.items
#4715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
🦋 Changeset detectedLatest commit: 75999ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
adrien2p
approved these changes
Aug 8, 2023
olivermrbl
changed the title
cart.items
|
/snapshot-this |
Merged
|
Crazy quick fix! thanks! If i am not mistaken you missed the addOrUpdateLineItems function. |
|
Right, thx @SimonsThijs! Now that you've seen what needs to be added, would you be up for tackling this one? |
|
Yes, should be no problem. @olivermrbl do you want me to just make a new pull request? |
|
That would be great, thanks! |
|
Alright #4725 ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adrien2p, what do you think about this? Resolves #4707
I think it's reasonable to remove the method on line item updates to always ensure correct shipping on the cart.
The more elegant way would be to validate if the shipping method is still applicable given the update to the items, but that is a more extensive change that I don't know if we should do given we will be modularizing the cart + shipping soon.