Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(): Test the create product workflow compensation #4716

Merged
merged 22 commits into from
Aug 9, 2023

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Aug 8, 2023

What
Integration tests to validate the workflow compensation.
Also, fix the transaction state when the workflow is compensating and some steps does not have any compensation

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023

🦋 Changeset detected

Latest commit: 33788a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@medusajs/orchestration Patch
@medusajs/workflows Patch
@medusajs/types Patch
@medusajs/medusa Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2023 2:11pm

@adrien2p adrien2p force-pushed the tests/create-product-workflow-compensation branch from ed71eb5 to 9341f32 Compare August 8, 2023 14:10
@adrien2p adrien2p marked this pull request as ready for review August 8, 2023 14:10
@adrien2p adrien2p requested a review from a team as a code owner August 8, 2023 14:10
@adrien2p adrien2p force-pushed the tests/create-product-workflow-compensation branch from d9fd4c2 to f763c3c Compare August 9, 2023 14:07
@adrien2p
Copy link
Member Author

adrien2p commented Aug 9, 2023

@olivermrbl if you could give this bad boy a review please, then we should be good to merge

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit ac866eb into develop Aug 9, 2023
@kodiakhq kodiakhq bot deleted the tests/create-product-workflow-compensation branch August 9, 2023 14:33
This was referenced Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants