Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflows): Data aggregation #4732

Merged
merged 13 commits into from
Aug 10, 2023
Merged

feat(workflows): Data aggregation #4732

merged 13 commits into from
Aug 10, 2023

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Aug 9, 2023

What

  • Add new pipe options to merge the data and have the ability to configure how to merge the data
    • merge - mergeAlias - mergeFrom
  • Also fix integration tests and apply the non retrieval in the cart workflow, meaning updating the end point as well

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023

⚠️ No Changeset found

Latest commit: 064aac7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 10, 2023 10:22am

@adrien2p adrien2p marked this pull request as ready for review August 10, 2023 10:24
@adrien2p adrien2p requested a review from a team as a code owner August 10, 2023 10:24
@adrien2p adrien2p requested a review from olivermrbl August 10, 2023 10:24
@olivermrbl olivermrbl changed the title Feat/workflows aggregator feat(workflows): Data aggregation Aug 10, 2023
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @carlos-r-l-rodrigues to sign off too 💪

Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@adrien2p adrien2p merged commit a268d2c into develop Aug 10, 2023
(input.merge || input.mergeAlias || input.mergeFrom) &&
functions.length
) {
const handler = functions.pop()!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Why do we only want to merge before the last handler? My steps broke after merging in these changes, because my middlewares were expecting the merged data shape too.

Copy link
Member Author

@adrien2p adrien2p Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to merge everything including the middleware result as we discussed on slack no? Previously, when used manually you could have placed the aggregator at any position you wanted before or after middleware's are applied, you can decide tou not use the automatic merge and instead use it manually, it is also possible.

Do you mean that instead we could apply it before every handlers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants