-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(workflows): Data aggregation #4732
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @carlos-r-l-rodrigues to sign off too 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
(input.merge || input.mergeAlias || input.mergeFrom) && | ||
functions.length | ||
) { | ||
const handler = functions.pop()! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Why do we only want to merge before the last handler? My steps broke after merging in these changes, because my middlewares were expecting the merged data shape too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea was to merge everything including the middleware result as we discussed on slack no? Previously, when used manually you could have placed the aggregator at any position you wanted before or after middleware's are applied, you can decide tou not use the automatic merge and instead use it manually, it is also possible.
Do you mean that instead we could apply it before every handlers?
What