Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove rimraf from prepare #4741

Merged
merged 4 commits into from
Aug 11, 2023
Merged

chore: Remove rimraf from prepare #4741

merged 4 commits into from
Aug 11, 2023

Conversation

olivermrbl
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Aug 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 11, 2023 2:55pm

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: a9e4dbc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@olivermrbl
Copy link
Contributor Author

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]

Latest commit: 2363a53

@olivermrbl olivermrbl changed the title use prepublishOnly + remove rimraf from prepare chore: Remove rimraf from prepare Aug 10, 2023
@olivermrbl olivermrbl marked this pull request as ready for review August 10, 2023 09:34
@olivermrbl olivermrbl requested a review from a team as a code owner August 10, 2023 09:34
@olivermrbl olivermrbl force-pushed the chore/fix-release-scripts branch 3 times, most recently from 6a84961 to 0c47097 Compare August 10, 2023 12:13
@olivermrbl olivermrbl requested a review from adrien2p August 10, 2023 12:29
@olivermrbl olivermrbl force-pushed the chore/fix-release-scripts branch from 0c47097 to 6f80995 Compare August 10, 2023 12:45
adrien2p
adrien2p approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olivermrbl olivermrbl force-pushed the chore/fix-release-scripts branch from 6f80995 to 4049c74 Compare August 10, 2023 12:50
@olivermrbl olivermrbl force-pushed the chore/fix-release-scripts branch from 4afcb5e to 5360fed Compare August 11, 2023 09:31
@olivermrbl olivermrbl force-pushed the chore/fix-release-scripts branch from 0dfa5f6 to b3d1429 Compare August 11, 2023 13:46
@olivermrbl olivermrbl merged commit 1d26375 into develop Aug 11, 2023
@olivermrbl olivermrbl deleted the chore/fix-release-scripts branch August 11, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olivermrbl @adrien2p @carlos-r-l-rodrigues