fix(admin-ui): Fix sign out in admin panel not redirecting correctly #4837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 78e2f21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why
Signing out from the user menu appeared to land you on the orders page, though any requests to the API would 401, landing you on a "broken" admin panel
How
The culprit turned out to be the
userobject fromuseAdminGetSessionsticking around, stale, after theuseAdminDeleteSessionmutation was called, as the refetch would fail. Thus, when the redirect to/loginhappened, this page would see there was a user on the session and redirect you to/. Used theremovemethod from theuseAdminGetSessionhook to ensure the stale user session data is removed from there, so that the login component doesn't automatically redirect anywhere.Resolves CORE-1471.