Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(medusa): List products with Remote Query #4969

Merged
merged 33 commits into from
Sep 12, 2023
Merged

feat(medusa): List products with Remote Query #4969

merged 33 commits into from
Sep 12, 2023

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Sep 6, 2023 •
edited
Loading

What

  • includes some type fixes in the DAL layer
  • List products including their prices and filtered by the sales channel as well as q parameter and category scope and all other filters
  • Assign shipping profile
  • ordering
  • Add missing columns in the product module
  • update product module migrations

Comment

  • In regards to the fields, we can pass whatever we want the module will only return the one that exists (default behavior), but on the other hand, that is not possible for the relations.

question

  • To simplify usage, should we expose the fields/relations available from the module to simplify building a query for the user and be aware of what the module provides

todo

  • Add back the support for the user to ask for fields/relations

@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 15a4861

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@medusajs/medusa Patch
@medusajs/link-modules Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/pricing Patch
@medusajs/product Patch
@medusajs/types Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2023 2:43pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2023 2:43pm

@olivermrbl
Copy link
Contributor

Exciting!! 😻

@vercel vercel bot temporarily deployed to Preview – api-reference September 7, 2023 16:33 Inactive
@vercel vercel bot temporarily deployed to Preview – medusa-docs September 7, 2023 16:37 Inactive
@adrien2p adrien2p marked this pull request as ready for review September 8, 2023 12:55
@adrien2p adrien2p requested a review from a team as a code owner September 8, 2023 12:55
@olivermrbl olivermrbl removed the blocked label Sep 8, 2023
@vercel vercel bot temporarily deployed to Preview – api-reference September 8, 2023 14:37 Inactive
@vercel vercel bot temporarily deployed to Preview – medusa-docs September 11, 2023 10:10 Inactive
@vercel vercel bot temporarily deployed to Preview – api-reference September 12, 2023 07:26 Inactive
@vercel vercel bot temporarily deployed to Preview – medusa-docs September 12, 2023 07:31 Inactive
@adrien2p
Copy link
Member Author

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]

Latest commit: afd4e72

olivermrbl
olivermrbl approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - lfg!

@olivermrbl
Copy link
Contributor

This flaky integration test in the product workflow keeps bugging us. We should fix it at some point 😅

CleanShot 2023-09-12 at 17 24 09@2x

@olivermrbl olivermrbl changed the title feat(medusa): store List products remote query feat(medusa): List products with Remote Query Sep 12, 2023
@adrien2p
Copy link
Member Author

This flaky integration test in the product workflow keeps bugging us. We should fix it at some point 😅

CleanShot 2023-09-12 at 17 24 09@2x

This is new this error no? I ll try to have a look at it soon

@kodiakhq kodiakhq bot merged commit 30863fe into develop Sep 12, 2023
@kodiakhq kodiakhq bot deleted the feat/list-produt-isolated-module branch September 12, 2023 15:55
This was referenced Sep 12, 2023
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues left review comments

@olivermrbl olivermrbl olivermrbl approved these changes

Assignees
No one assigned
Labels
automerge version: minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrien2p @olivermrbl @carlos-r-l-rodrigues