-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(modules-sdk,orchestration): to remote joiner query #4974
Conversation
🦋 Changeset detectedLatest commit: 821c4e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe just adding a unit test would be nice
@adrien2p @carlos-r-l-rodrigues – I don't think I have fully understood the purpose of this helper. Can you add some more detail to it and perhaps provide a couple of |
At the moment, when you use the remote query, you can pass a RemoteJoinerQuery or a strong (gql). The RemoteJoinerQuery is not that simple to use and contains some properties that can be auto populated. This util aims to simplify the object to pass and take care of building the appropriate RemoteJoinerQuery |
This helps, thanks. Will we need to use this anywhere now? |
We will need to see, but might be easier to build an object with filters etc than a gql string. specially with complex filters and special filters |
Helper function to transform js/json object into RemoteJoinerQuery format.
outputs: