Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(orchestration,link-modules,pricing,types): fix shippingprofile errror outside of core + change link alias name #5025

Merged
merged 12 commits into from
Sep 13, 2023

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Sep 12, 2023

No description provided.

…ror outside of core + change link alias name
@riqwan riqwan requested a review from a team as a code owner September 12, 2023 10:14
@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2023

🦋 Changeset detected

Latest commit: 461347b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@medusajs/orchestration Patch
@medusajs/link-modules Patch
@medusajs/pricing Patch
@medusajs/types Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 8:53am
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 8:53am

Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/pricing/src/services/pricing-module.ts Outdated Show resolved Hide resolved
@riqwan riqwan removed the automerge label Sep 12, 2023
@riqwan
Copy link
Contributor Author

riqwan commented Sep 12, 2023

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]

Latest commit: 30863fe

@riqwan
Copy link
Contributor Author

riqwan commented Sep 13, 2023

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]

Latest commit: 05fcfd8

@riqwan
Copy link
Contributor Author

riqwan commented Sep 13, 2023

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]

Latest commit: 05fcfd8

@riqwan
Copy link
Contributor Author

riqwan commented Sep 13, 2023

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]

Latest commit: 05fcfd8

Comment on lines 35 to 46
{
name: "calculated_prices",
args: {
methodOverride: "calculatePrices",
},
},
{
name: "calculated_price",
args: {
methodOverride: "calculatePrice",
},
},
Copy link
Contributor

@olivermrbl olivermrbl Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought:

I think for the first iteration and to not rush into a pattern, the call to calculate prices should be done separately from the Remote Query call.

So right now, we will only use the Remote Query engine as a way to collect raw data for further processing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. This won't be committed. I'm just jesting with the idea and using this PR to create snapshots.

@vercel vercel bot temporarily deployed to Preview – api-reference September 13, 2023 08:48 Inactive
@vercel vercel bot temporarily deployed to Preview – medusa-docs September 13, 2023 08:53 Inactive
@riqwan riqwan merged commit 3d68be2 into develop Sep 13, 2023
@riqwan riqwan deleted the fix/joiner-internal-services branch September 13, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants