Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed a miss numbering from 4 to 3 #5035

Merged
merged 7 commits into from
Sep 19, 2023
Merged

Changed a miss numbering from 4 to 3 #5035

merged 7 commits into from
Sep 19, 2023

Conversation

S-IR
Copy link
Contributor

@S-IR S-IR commented Sep 13, 2023

No description provided.

@S-IR S-IR requested a review from a team as a code owner September 13, 2023 07:35
@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: f84f554

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 13, 2023

@S-IR is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

shahednasser
shahednasser approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for noticing this 😄

adrien2p
adrien2p approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahednasser shahednasser merged commit 5b557d3 into medusajs:develop Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p approved these changes

@shahednasser shahednasser shahednasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@S-IR @adrien2p @shahednasser