Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa): Admin list product with product isolated module #5046

Merged
merged 21 commits into from
Sep 22, 2023

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Sep 13, 2023

What
First iteration:
Admin list products return everything but does not include proper filtering by discount id or price list id. Also, same as the previous pr, the fields/expand is not included

depends on #5130

@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2023

🦋 Changeset detected

Latest commit: 20de14e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2023 10:45am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2023 10:45am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2023 10:45am

@vercel vercel bot temporarily deployed to Preview – api-reference September 14, 2023 09:31 Inactive
@vercel vercel bot temporarily deployed to Preview – medusa-docs September 14, 2023 09:36 Inactive
@adrien2p adrien2p marked this pull request as ready for review September 14, 2023 10:17
@adrien2p adrien2p requested a review from a team as a code owner September 14, 2023 10:17
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with nits! 💪

packages/medusa/src/services/price-list.ts Outdated Show resolved Hide resolved
packages/medusa/src/services/price-list.ts Outdated Show resolved Hide resolved
@olivermrbl olivermrbl changed the title feat: admin list product with product isolated module feat(medusa): Admin list product with product isolated module Sep 18, 2023
@vercel vercel bot temporarily deployed to Preview – api-reference September 19, 2023 08:59 Inactive
@vercel vercel bot temporarily deployed to Preview – api-reference September 19, 2023 14:15 Inactive
@vercel vercel bot temporarily deployed to Preview – medusa-docs September 19, 2023 14:20 Inactive
@vercel vercel bot temporarily deployed to Preview – api-reference September 20, 2023 11:21 Inactive
@vercel vercel bot temporarily deployed to Preview – medusa-docs September 20, 2023 11:27 Inactive
@olivermrbl
Copy link
Contributor

Same goes for this one 💪

@vercel vercel bot temporarily deployed to Preview – docs-ui September 22, 2023 07:24 Inactive
@vercel vercel bot temporarily deployed to Preview – medusa-docs September 22, 2023 07:24 Inactive
@vercel vercel bot temporarily deployed to Preview – api-reference September 22, 2023 07:25 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-ui September 22, 2023 07:32 Inactive
@vercel vercel bot temporarily deployed to Preview – api-reference September 22, 2023 07:32 Inactive
@vercel vercel bot temporarily deployed to Preview – medusa-docs September 22, 2023 07:33 Inactive
@kodiakhq kodiakhq bot merged commit f151260 into develop Sep 22, 2023
@kodiakhq kodiakhq bot deleted the feat/admin-list-product-isolated-module branch September 22, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants