Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin-ui): Add Polish translation #5101

Merged
merged 3 commits into from
Sep 20, 2023
Merged

feat(admin-ui): Add Polish translation #5101

merged 3 commits into from
Sep 20, 2023

Conversation

chemicalkosek
Copy link
Contributor

@chemicalkosek chemicalkosek commented Sep 17, 2023

Added Polish translation

For Polish folks: I had trouble with some wording of Polish equivalents. And I would like for them to be good.

  • Inventory - Shopify uses Zapasy. I thought to use Stan magazynowy. I'm using them interchangeably for now, depending on the UI.
  • Inventory Item - Pozycja magazynowa, przedmioty magazynowe, pozycja zapasu?
  • Inventory Level - Poziom zapasu?
  • Price Lists - Cenniki? Listy cen? Currently using Cenniki. Not sure about that.
  • batch job - zadanie zbiorcze?
  • payment provider, fulfillment provider - provider translated as operator, not dostawca.
  • fulfillment - realizacja
  • handle - slug
  • item (cart item) - decided on przedmiot, not pozycja.
  • status - stan or status?

Any critique and suggestions are welcome, thought I would prefer for this PR to go through.
I would address them in a follow-up PR after this one is merged and released.
Would like to see how it works in deployed UI (phrase lengths, used context etc)

cc: @uro

@chemicalkosek chemicalkosek requested a review from a team as a code owner September 17, 2023 14:09
@changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2023

🦋 Changeset detected

Latest commit: 3cad94c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/admin-ui Patch
@medusajs/admin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 17, 2023

@chemicalkosek is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@chemicalkosek chemicalkosek changed the title Add Polish translation feat(admin-ui): Add Polish translation Sep 17, 2023
@olivermrbl
Copy link
Contributor

Thanks for this @chemicalkosek – really appreciate it. Can't be of much help with your considerations though 😅

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will let this hang a couple of days before we merge, in case someone has input to your suggestions

@vercel
Copy link

vercel bot commented Sep 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2023 0:26am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2023 0:26am

@olivermrbl olivermrbl merged commit 15a1c55 into medusajs:develop Sep 20, 2023
@github-actions github-actions bot mentioned this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants