Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(medusa): Migrate remote query usage in store product domain to use an object #5131

Merged
merged 4 commits into from
Sep 21, 2023
Merged

feat(medusa): Migrate remote query usage in store product domain to use an object #5131

merged 4 commits into from
Sep 21, 2023

Conversation

adrien2p
Copy link
Member

What
Move from using a gql string to an object for easier manipulation later. depends on #5130

@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0c0e816

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 11:34am
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 11:34am

@adrien2p adrien2p marked this pull request as ready for review September 19, 2023 09:00
@adrien2p adrien2p requested a review from a team as a code owner September 19, 2023 09:00
@vercel vercel bot temporarily deployed to Preview – api-reference September 19, 2023 14:08 Inactive
@vercel vercel bot temporarily deployed to Preview – medusa-docs September 19, 2023 14:12 Inactive
@vercel vercel bot temporarily deployed to Preview – api-reference September 20, 2023 11:29 Inactive
@vercel vercel bot temporarily deployed to Preview – medusa-docs September 20, 2023 11:34 Inactive
olivermrbl
olivermrbl approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olivermrbl olivermrbl merged commit 19c5d5b into develop Sep 21, 2023
@olivermrbl olivermrbl deleted the feat/migrate-remote-query-usage-gql-to-obj branch September 21, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrien2p @olivermrbl