Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-medusa-app): fix inconsistency in checking errors in migrations #5189

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

shahednasser
Copy link
Member

Improves checking for errors in migration by checking the content of the migrations table in the database.

@shahednasser shahednasser requested a review from a team as a code owner September 22, 2023 14:02
@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2023

🦋 Changeset detected

Latest commit: 6ccf906

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-medusa-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2023 10:02am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2023 10:02am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2023 10:02am

@shahednasser
Copy link
Member Author

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]

Latest commit: 0c9d5ea

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olivermrbl olivermrbl merged commit 18a05de into develop Sep 29, 2023
@olivermrbl olivermrbl deleted the fix/cma-migration-error branch September 29, 2023 12:26
This was referenced Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants