Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix z-index across projects #5234

Merged
merged 3 commits into from
Sep 27, 2023
Merged

docs: fix z-index across projects #5234

merged 3 commits into from
Sep 27, 2023

Conversation

shahednasser
Copy link
Member

These changes do not affect the main docs as there are different layers to it since it's built with Docusaurus.

  • Fix z-index of different components, mainly the Navbar and Sidebar components.
  • Allow scroll only in content, i.e. give a fixed height to the body and set overflow on content
  • Add z-index class to Search component in docs project due to docusaurus's z-index usage.

@shahednasser shahednasser requested a review from a team as a code owner September 27, 2023 13:12
@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2023

⚠️ No Changeset found

Latest commit: 1cb4329

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🛑 Canceled (Inspect) Sep 27, 2023 1:21pm
docs-ui 🛑 Canceled (Inspect) Sep 27, 2023 1:21pm
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 1:21pm

@vercel vercel bot temporarily deployed to Preview – docs-ui September 27, 2023 13:16 Inactive
@vercel vercel bot temporarily deployed to Preview – api-reference September 27, 2023 13:19 Inactive
@vercel vercel bot temporarily deployed to Preview – medusa-docs September 27, 2023 13:21 Inactive
@shahednasser shahednasser merged commit 6942a90 into develop Sep 27, 2023
@shahednasser shahednasser deleted the docs/fix-z-index branch September 27, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant