feat(pricing,types): addPrice and removePricreRules APIs #5237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x.ts Co-authored-by: Riqwan Thamir <[email protected]>
Co-authored-by: Riqwan Thamir <[email protected]>
riqwan
changed the title
riqwan
changed the title
adrien2p
approved these changes
Oct 2, 2023
packages/pricing/integration-tests/__fixtures__/price-set/index.ts
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| const priceSets = await Promise.all( | ||
| data.map(async (d) => { |
There was a problem hiding this comment.
yes I see what you mean, indeed having an id from the start would be the easiest way to do it. for that we could have a service method that only create the entities without persisting. Then adding @onInit on the before create would take care of assigning the id automatically when manager.create is called. Maybe this is something we can think of in another iteration unless you think it would be quick to do. Let me know what you think about it.
ps: this might be a too early optimisation but just want your takes on it for the future if we fall into it
This was referenced Oct 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.