Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Sendgrid Plugin Documentation #5284

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

annalbirena
Copy link
Contributor

Added a specific note regarding the use of localization keys in the context field of the cart, emphasizing the necessity of including these keys under cart.context.locale

@annalbirena annalbirena requested a review from a team as a code owner October 3, 2023 23:24
@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2023

⚠️ No Changeset found

Latest commit: 782a85c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 3, 2023

@annalbirena is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Just have a small requested change.

www/apps/docs/content/plugins/notifications/sendgrid.mdx Outdated Show resolved Hide resolved
@annalbirena
Copy link
Contributor Author

It looks better now!

Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shahednasser shahednasser merged commit b6bea74 into medusajs:develop Oct 5, 2023
adrien2p pushed a commit that referenced this pull request Oct 5, 2023
* Update sendgrid.mdx

* Update www/apps/docs/content/plugins/notifications/sendgrid.mdx

Co-authored-by: Shahed Nasser <[email protected]>

---------

Co-authored-by: Shahed Nasser <[email protected]>
pKorsholm pushed a commit that referenced this pull request Oct 11, 2023
* Update sendgrid.mdx

* Update www/apps/docs/content/plugins/notifications/sendgrid.mdx

Co-authored-by: Shahed Nasser <[email protected]>

---------

Co-authored-by: Shahed Nasser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants